Apply @needs_local_scope to cell magics. #11542
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While technically this will not be completely needed (at cell magics cannot be in nested scope), it make the API a tiny bit more consistent between line and cell magics. (Bug report I recieved personally that will be submitted later)
Carreau
force-pushed
the
local-scope
branch
2 times, most recently
from
25e9f03
to
43246e6
Compare
|
Did you get round to filing the bug report about this? |
|
No, I need to translate it from french. I'm slowly coming back the cluster was under maintnance for the last few days so it was taking all my time. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While technically this will not be completely needed (at cell magics
cannot be in nested scope), it make the API a tiny bit more consistent
between line and cell magics.
(Bug report I recieved personally that will be submitted later)